Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "found" field added to the Products Connection types #804

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Sep 16, 2023

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Fixed ignore sticky post bug when reverse pagination products.
  • Renames allowedCountryStates query to countryStates.
  • Adds countries query for get a complete list all countries not just the one the store ships to.
  • Adds the connection field found the product connections see example usage below
  • Added lowStockAmount field to InventoriedProduct interface.
{
  products(first: 20) {
    found
    pageInfo {
      endCursor
    }
    nodes {
      id
    }
  }
}

The found field should only be resolved on the initial query from a connection without after or before cursors and will return null when cursors are provided. See screenshots below for output examples.
image
image

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 merged commit 134dc5e into wp-graphql:develop Sep 16, 2023
14 checks passed
@kidunot89 kidunot89 deleted the feat/products-connection-found-field branch September 16, 2023 03:31
@kidunot89 kidunot89 added enhancement New feature or request breaking change Solution will break some older solutions bugfix Implements bugfix labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Solution will break some older solutions bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant