Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVIF Support: settings page #772

Closed
remyperona opened this issue Jan 3, 2024 · 5 comments · Fixed by #780
Closed

AVIF Support: settings page #772

remyperona opened this issue Jan 3, 2024 · 5 comments · Fixed by #780
Assignees
Labels
effort [XS] < 1 day of estimated development time

Comments

@remyperona
Copy link
Contributor

remyperona commented Jan 3, 2024

Scope a solution ✅

In views/part-settings-web.php

  • Update the title to Next-gen image format
  • Update the WebP checkbox to Avif checkbox, with new option name, label, described
  • Add the description for the option using the "imagify-info" class
  • Add a separator between this option and the other part
  • Update the label for the display option

In views/part-settings-webp-missing-message.php

  • Update the label replacing WebP by Next-Gen

Estimate the effort ✅

Effort [XS]

@remyperona remyperona added the effort [XS] < 1 day of estimated development time label Jan 3, 2024
@Miraeld
Copy link
Contributor

Miraeld commented Jan 5, 2024

@Tabrisrp , Umm, when you say

Update the WebP checkbox to Avif checkbox, with new option name, label, described

Do you mean replacing WebP by AVIF or adding a checkbox for AVIF which would result in 2 times approximately the same form elements but with different name (WebP & AVIF)

@MathieuLamiot
Copy link
Contributor

@Miraeld I think it is replacing and not adding a similar form. You can refer to the EPIC card with the product team's specifications: https://www.notion.so/wpmedia/AVIF-Imagify-Plugin-4a870cab6e0d4232a85962f0b4c1c63a?pvs=4#24bc7a3f47764c878aed0e64559f1752
The behavior will change a bit: if AVIF is checked, we generate AVIF. If it is not checked, we generate WebP.

(@piotrbak and @Tabrisrp for confirmation)

@MathieuLamiot
Copy link
Contributor

Could be a nice first issue to keep for Opeyemi

@remyperona
Copy link
Contributor Author

Indeed we are replacing the existing WebP option with a new one for AVIF

@Mai-Saad
Copy link

Mai-Saad commented Jan 12, 2024

@Tabrisrp Shall this ticket includes updating the button name from Generate Missing WEBP Versions to Generate Missing Next-Gen Images Versions or it's the scope of another ticket?
Currently, it is still WEBP:
Screenshot from 2024-01-12 16-00-58
Another thing, if we check the AVIF options and saved, it will be automatically unchecked. Is this out of scope here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort [XS] < 1 day of estimated development time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants