Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with gravity forms noconflict mode #919

Closed
wordpressfan opened this issue Nov 12, 2024 · 5 comments · Fixed by #924
Closed

Conflict with gravity forms noconflict mode #919

wordpressfan opened this issue Nov 12, 2024 · 5 comments · Fixed by #924
Assignees
Milestone

Comments

@wordpressfan
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version Yes
  • Used the search feature to ensure that the bug hasn’t been reported before Yes

Describe the bug

When gravity forms noconflict mode is enabled, the imagify pricing modal is showing on the page without any styling.

To Reproduce
Steps to reproduce the behavior:

  1. Install and activate gravity forms
  2. Install and activate imagify plugin
  3. Go to gravity forms settings page from the admin menu
  4. Enable no conflict mode and save the form by clicking on Save Changes button
  5. You will see the modal in the footer without any styling.

Expected behavior
It should behave correctly and hide the modal by default.

Screenshots

Image

Additional context

Slack discussion: https://wp-media.slack.com/archives/C045P1RA2/p1731310030013799

Possible solutions:

  1. Insert inline CSS to hide the modal style="display: none;"
  2. Use the following filters to add our styles/scripts into no conflict mode:

https://docs.gravityforms.com/gform_noconflict_scripts/
https://docs.gravityforms.com/gform_noconflict_styles/

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@MathieuLamiot
Copy link
Contributor

dev-team-escalation to consider as well for the fix.

@MathieuLamiot MathieuLamiot added this to the 2.2.4 milestone Nov 19, 2024
@Khadreal
Copy link
Contributor

Khadreal commented Nov 20, 2024

The PR created here fixed this but needs to be tested

@MathieuLamiot MathieuLamiot linked a pull request Nov 20, 2024 that will close this issue
7 tasks
@Mai-Saad Mai-Saad self-assigned this Dec 16, 2024
@Mai-Saad
Copy link

Mai-Saad commented Dec 16, 2024

Acceptance criteria:

  • The banner isnot displayed inside gravity form settings while no conflict is on/off
  • The upgrade button is working in admin bar (green banner), settings page and bulk optimization (for starter with remaining quota > 20%)
  • The red banner displayed correctly when the remaining quota is < = 20% (upgrade links are working in admin bar, settings, bulk optimization)

@piotrbak what do you think?

@Mai-Saad
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants