Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVIF Rewrite rules #774

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jan 5, 2024

Description

This PR adds the rewrite rules management for the AVIF picture format

Fixes #764

Type of change

  • New feature (non-breaking change which adds functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld self-assigned this Jan 5, 2024
@Miraeld Miraeld changed the title Enhancement/764 add avif rewrite rules Add AVIF Rewrite rules Jan 5, 2024
@Miraeld Miraeld changed the base branch from develop to feature/avif January 5, 2024 05:24
Copy link
Contributor

@remyperona remyperona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do the same changes in the Nginx file

classes/Avif/RewriteRules/Apache.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Apache.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Apache.php Outdated Show resolved Hide resolved
@Miraeld Miraeld requested a review from remyperona January 11, 2024 14:38
Copy link
Contributor

@Khadreal Khadreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Contributor

@remyperona remyperona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the instantiation and loading of the init method of the class, but I want to move to the container + event manager instead, so we could do it once they are in

classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
classes/Avif/RewriteRules/Display.php Outdated Show resolved Hide resolved
@Miraeld Miraeld requested a review from remyperona January 17, 2024 04:11
@remyperona remyperona merged commit 1dc3a71 into feature/avif Jan 18, 2024
1 check failed
@remyperona remyperona deleted the enhancement/764-add_avif_rewrite_rules branch January 18, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVIF support: rewrite rules
3 participants