Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #826 Only generate missing next-gen when enabling AVIF option #828

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

remyperona
Copy link
Contributor

Description

This PR changes the action happening when enabling the AVIF option. Instead of running the bulk optimize process, it runs the generate missing next-gen process, so already optimized or generated images should not be recreated for nothing.

Fixes #826

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona added this to the 2.2 milestone Feb 28, 2024
@remyperona remyperona requested a review from a team February 28, 2024 20:36
@remyperona remyperona self-assigned this Feb 28, 2024
Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@Mai-Saad Mai-Saad merged commit 85edeba into feature/avif Feb 29, 2024
1 check passed
@Mai-Saad Mai-Saad deleted the fix/826-prevent-reoptimize branch February 29, 2024 11:17
@remyperona remyperona mentioned this pull request Feb 29, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants