-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of next gen images with first settings save of avif option #834
Fix generation of next gen images with first settings save of avif option #834
Conversation
…nts in code to explain what is going on there.
…irst-settings-save
Don't block the PR for this, but it could be nice to update the doc string or comment the method here to clearly state:
|
Now AVIF is created for 1st activation. with the following note:
|
@Mai-Saad This behaviour is acceptable for the initial 2.2 |
@Mai-Saad @wordpressfan I can see that the PR is still a draft/in-progress. Where are we with this one? |
I think we are fine here based on the comments above but I requested a review from @Mai-Saad @Tabrisrp and @MathieuLamiot to add their review. |
Description
Run next gen generation for the first settings save and add few comments in code to explain what is going on there.
Fixes #825
Documentation
User documentation
This will trigger generating next generation images when enabling the avif option and rewrite rules.
Technical documentation
Explain how this code works. Diagram & drawings are welcomed.
Type of change
Delete options that are not relevant.
New dependencies
List any new dependencies that are required for this change.
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Checklists
Feature validation
Documentation
Code style
Observability
Risks