[MERL-194] link styles #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW green is a horrible color to try and keep compliant against |
apmatthews
reviewed
Mar 28, 2022
josephfusco
commented
Mar 28, 2022
| @@ -3,6 +3,7 @@ | |||
| .content { | |||
| max-width: $grid-max-width; | |||
| margin: 0 auto; | |||
| line-height: 1.6875; | |||
There was a problem hiding this comment.
Adjusted for legibility. This is what the WPE blog is using.
theodesp
approved these changes
Mar 29, 2022
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went with the same hover pattern as our blog. https://wpengine.com/blog/wp-engine-stands-with-ukraine/
Link underlines by default with no underline on hover/focus.
Since I opted to use theme colors, I adjusted them slightly to optimize legibility as the darker colors were getting lost against the black text. I'm not in love with these colors but we can play around with the default theme colors later as I imagine most users will be updating these as they do with the default WordPress themes.