Remove robotInit in favour of Robot constructor #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamCarlberg
reviewed
Jul 27, 2024
| @@ -14,7 +14,7 @@ | |||
| * The VM is configured to automatically run this class, and to call the | |||
| * functions corresponding to each mode, as described in the TimedRobot | |||
| * documentation. If you change the name of this class or the package after | |||
| * creating this project, you must also update the build.properties file in | |||
| * creating this project, you must also update the build.properties file in | |||
There was a problem hiding this comment.
build.properties was with the old (old) Ant build system. It would be nice to update this but not necessarily in this PR
SamCarlberg
previously approved these changes
Jul 27, 2024
|
Shouldn't the same thing be done for C++? |
|
Robot builder supports C++ 💀 |
sciencewhiz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See wpilibsuite/allwpilib#6845