-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add launcher shortcuts on Linux #458
Conversation
1847f3d
to
6459695
Compare
Using a category of Robotics instead of Development might be more relevant |
Do custom categories like Robotics work? |
We probably don't want a .desktop for ToolsUpdater.
|
It's in the spec. https://specifications.freedesktop.org/menu-spec/latest/additional-category-registry.html |
6459695
to
2132291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried this on Ubuntu 24.04, and I didn't get tool files installed to ~/local/share/applications, just VS code
Was it a tools only run? Assuming it was its fixed now. |
cf800c1
to
dfebd75
Compare
Yes it was tools only, and it's fixed now |
It seems like most of the tools don't show up in the dock when I ran them |
For me tho showed up after a bit of a wait. I think I might've had to interact with the window as well? |
You can see in the below clip the icon does appear it just takes a while Screencast.from.2024-10-26.23-03-13.webm |
funny note from this, if I have the same version of Choreo installed from Choreo and the installer the installer version will override the launch icon for the Choreo install |
There isn't a delay if launching either the executable or shell script directly, only when using the launcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The java tools StartupWMClass weren't correct
The .desktop files are written with CRLF line endings |
idrk how we can fix this, the dotnet formatter will want everything in the file to be crlf |
I dont think it being written with CRLF endings is an issue and even if it is its seperate to this PR, the vscode desktop file already had this problem. |
Doesn't add desktop shortcuts due to complications with how gnome handles desktop files Resolves wpilibsuite#136 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
bebadad
to
8ef6ed5
Compare
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
8ef6ed5
to
76951ae
Compare
This still didn't sort correctly. The following seems to work though. diff --git a/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs b/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs
index 989b108..b9a1744 100644
--- a/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs
+++ b/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs
@@ -42,7 +42,7 @@ namespace WPILibInstaller.ViewModels
[Desktop Entry]
Version=1.0
Type=Application
-Categories=Science & Maths
+Categories=Robotics;Science
Name={name} {frcYear}
Comment={nameNoWPILib} tool for the 2025 FIRST Robotics Competition season
Exec={configurationProvider.InstallDirectory}/tools/{nameNoWPILib}.sh
@@ -59,7 +59,7 @@ StartupWMClass={wmClass}
[Desktop Entry]
Version=1.0
Type=Application
-Categories=Robotics
+Categories=Robotics;Science
Name={name} {frcYear}
Comment={name} tool for the 2025 FIRST Robotics Competition season
Exec={configurationProvider.InstallDirectory}/tools/{name}.sh |
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Needs a shortcut for elastic |
On Ubuntu 24.04, only a few are showing up in the launcher (Advantagescope, Elastic, VS Code) |
Doesn't add desktop shortcuts due to complications with how gnome
handles desktop files
Resolves #136