Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WMClass for Elastic #516

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

sciencewhiz
Copy link
Contributor

No description provided.

@Gold872
Copy link
Contributor

Gold872 commented Jan 15, 2025

Is this related to this issue? Gold872/elastic-dashboard#198

@sciencewhiz
Copy link
Contributor Author

It's only a little related. The way the WPILib installation uses scripts, even if you added an icon in Elastic itself, it wouldn't show up in the WPILib installation. This fix makes sure the WPILib icon is shown in the WPILib installation regardless of what is done in Elastic.

@PeterJohnson PeterJohnson merged commit 9b3a00a into wpilibsuite:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants