Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sysid] Update presets #6235

Closed
calcmogul opened this issue Jan 15, 2024 · 0 comments · Fixed by #6460
Closed

[sysid] Update presets #6235

calcmogul opened this issue Jan 15, 2024 · 0 comments · Fixed by #6460
Labels
component: sysid SysId app type: fix Iterations on existing features or infrastructure.

Comments

@calcmogul
Copy link
Member

calcmogul commented Jan 15, 2024

SysId currently supports old Phoenix 5 units for gains, which may no longer be relevant with the new logging. We also want to remove the CPR setting in #6234 because the logs absorb the factor, but that old preset might be in the way.

If I recall correctly, modern CTRE vendordep versions use SI units (or at least physical units instead of ticks).

@calcmogul calcmogul added type: fix Iterations on existing features or infrastructure. component: sysid SysId app labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sysid SysId app type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant