Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vendor dep error handling for malformed files #229

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

sciencewhiz
Copy link
Contributor

Does not parse hidden files. Fixes wpilibsuite/GradleRIO#726
Identifies file that failed to load or parse

Does not parse hidden files. Fixes wpilibsuite/GradleRIO#726
Identifies file that failed to load or parse
@sciencewhiz
Copy link
Contributor Author

The error printed before was from deep within GSON, such as:

An exception occurred applying plugin request [id: 'edu.wpi.first.GradleRIO', version: '2024.2.1']
> Failed to apply plugin class 'edu.wpi.first.gradlerio.wpi.WPIPlugin'.
   > Could not create an instance of type edu.wpi.first.gradlerio.wpi.WPIExtension.
      > java.nio.charset.MalformedInputException: Input length = 1

now its:

An exception occurred applying plugin request [id: 'edu.wpi.first.GradleRIO', version: '2025.1.1-beta-1-8']
> Failed to apply plugin class 'edu.wpi.first.gradlerio.wpi.WPIPlugin'.
   > Could not create an instance of type edu.wpi.first.gradlerio.wpi.WPIExtension.
      > Failed to parse vendor dependency: ._REVLib.json

@PeterJohnson PeterJohnson merged commit 7730d28 into wpilibsuite:main Dec 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vendordeps glob should skip hidden files
3 participants