Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Windows compatibility #115

Closed
wants to merge 3 commits into from
Closed

Improved Windows compatibility #115

wants to merge 3 commits into from

Conversation

Reelix
Copy link

@Reelix Reelix commented Oct 17, 2019

Added code to make memory_usage Windows compatible

Added code to make memory_usage Windows compatible
@Reelix Reelix changed the title Updated helper.rb Improved Windows compatibility Oct 17, 2019
Removed redundant require
@coveralls
Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d97e91b on Reelix:patch-1 into 6d240fa on wpscanteam:master.

Code changes to make travis happy
@erwanlr
Copy link
Member

erwanlr commented Oct 18, 2019

Thanks for the PR, I was not aware of such Gem.

I've tried to use it to get the memory on MacOSX but it seems harder than I thought.

Nevertheless, there is the get_process_mem which seems to be an easy way to get the memory and it uses sys-proctable if Windows is detected.

So I've committed the changes in master and will release a new version for you to try when all specs will pass.

I will close this PR and re-open the original issue.

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants