feat: add support for decoding roomID from Space events #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecates get_global_id in favour of try_global_id with error reporting
|
If the approach is ok, I will modify the examples to use |
aknarts
reviewed
Dec 19, 2023
src/types.rs
Outdated
| if uuid.as_bytes()[7] == b'2' { | ||
| uuid.replace_range(7..8, "0"); | ||
| } else { | ||
| panic!("Space created uuid {uuid} could not be not patched"); |
There was a problem hiding this comment.
I really do not like a panic, I would rather return an Error since we already are returning a Result
There was a problem hiding this comment.
something like
crate::error::ErrorKind::Api(
"Space created uuid {uuid} could not be not patched",
)There was a problem hiding this comment.
oh yes, that one slipped through the cracks from a previous version! I'll remove it
added 7 commits
December 19, 2023 11:37
sgrimee
force-pushed
the
42-api_alignment_sgrimee
branch
from
5e96902
to
d944c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space events have a different way to report the target room id than message events. It also varies based on the Space event type, and the Create event requires patching of the UUID. §
This PR includes changes to make this all transparent in the
get_global_id.At the same time, it deprecates
get_global_idin favour oftry_global_idwith error reporting.