feat(workspaces): add simple workspace support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are operating in a workspace then require the `--manifest-path` option to disambiguate which workspace member we should bump. I had to update the toml_edit dependency because of a build failure. Additionally I added a new dependency `same_file` to easily and safely compare manifests file paths.
2 tasks
|
Do you think it would be better to infer the workspace member (and require confirmation) by current work directory? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are operating in a workspace then require the
--manifest-pathoption to disambiguate which workspace member we should bump.
I had to update the toml_edit dependency because of a build
failure. Additionally I added a new dependency
same_fileto easily andsafely compare manifests file paths.
Happy to change the approach if a better one is recommended.