Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user check dialog #28

Merged
merged 16 commits into from
Mar 29, 2024
Merged

add user check dialog #28

merged 16 commits into from
Mar 29, 2024

Conversation

huangliang992
Copy link
Contributor

@huangliang992 huangliang992 commented Mar 25, 2024 •
edited
Loading

open a check dialog for user to select fields to mock and methods to test

screenshot

yaronyam
yaronyam reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@yaronyam yaronyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature 🙇 I think that ideally, test customization option should be available on demand rather then a preconfigured setting. for instance on existing TestMe test generation dialog, at end of each test template name - would be great to have some arrow/icon/dots - that opens a sub menu with "Customize..." entry. so user can choose to generate test with defaults as currently done of go through another dialog to customize tested code. But for now, this is a good step forward.

src/main/java/com/weirddev/testme/intellij/action/CreateTestMeAction.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/action/CreateTestMeAction.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/action/CreateTestMeAction.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/configuration/TestMeConfig.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/generator/TestTemplateContextBuilder.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/classconfigdialog/CreateTestMeDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/classconfigdialog/CreateTestMeDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/classconfigdialog/CreateTestMeDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/classconfigdialog/CreateTestMeDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/settings/TestMeSettingsForm.form Outdated Show resolved Hide resolved
@huangliang992
update
810722a
@huangliang992
update
ece9a92
@huangliang992
update
a596d62
@huangliang992
update
9716098
@huangliang992
Merge branch 'master' of https://github.com/huangliang992/testme-idea …
6c1f6be 
…into feature/add-user-select-dialog

# Conflicts:
#	src/main/java/com/weirddev/testme/intellij/template/context/MockitoMockBuilder.java
#	src/main/java/com/weirddev/testme/intellij/template/context/PowerMockBuilder.java
yaronyam
yaronyam reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@yaronyam yaronyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution. I'm sure most users would value this feature as I do. Posted mainly technical comments of minor issues. adding at least 1 integration test with custom selections would be nice. If you're short on time - let me know, I can merge and deal with those later. Big thank you, impressive work.

src/main/java/com/weirddev/testme/intellij/ui/customizedialog/CustomizeTestDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/customizedialog/CustomizeTestDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/customizedialog/CustomizeTestDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/customizedialog/CustomizeTestDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/customizedialog/CustomizeTestDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/ui/customizedialog/CustomizeTestDialog.java Outdated Show resolved Hide resolved
src/main/java/com/weirddev/testme/intellij/template/context/PowerMockBuilder.java Outdated Show resolved Hide resolved
@huangliang992
Copy link
Contributor Author

Great contribution. I'm sure most users would value this feature as I do. Posted mainly technical comments of minor issues. adding at least 1 integration test with custom selections would be nice. If you're short on time - let me know, I can merge and deal with those later. Big thank you, impressive work.

I'm sorry, i fixed the issues but i don't known how to make a integration test with custom selections.

yaronyam
yaronyam approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@yaronyam yaronyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR 🙇

...tionTest/java/com/weirddev/testme/intellij/generator/TestMeGeneratorJunit4PowerMockTest.java
testMeConfig.setOpenCustomizeTestDialog(true);
final FileTemplateConfig fileTemplateConfig = new FileTemplateConfig(testMeConfig);
List<String> selectedFieldNameList = new ArrayList<>();
selectedFieldNameList.add("result");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, project jdk version has bean upgraded in recent years. can use List.of()

@yaronyam yaronyam merged commit 59c7491 into wrdv:master Mar 29, 2024
5 checks passed
@yaronyam
Copy link
Member

Released in TestMe plugin version 6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronyam yaronyam yaronyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huangliang992 @yaronyam