Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: SimulationTimestampPstateSet should not record multiple pstate changes for the same time #100

Closed
ryantanaka opened this issue Apr 11, 2019 · 1 comment
Closed

Bug Fix: SimulationTimestampPstateSet should not record multiple pstate changes for the same time #100

ryantanaka opened this issue Apr 11, 2019 · 1 comment
Assignees
@ryantanaka
Labels
bug
Milestone
1.4

Comments

@ryantanaka
Copy link
Member

@spenceralbrecht pointed out a bug in output from SimulationOutput::dumpHostEnergyConsumptionJSON(). If consecutive calls to Simulation::setPstate() are made, then the p-state trace from simulation output will show multiple p-states for the same simulated time. So, I need to make sure that when consecutive calls are made to Simulation::setPstate() during the same simulated time, only one timestamp is recorded for the final call.
@ryantanaka ryantanaka added the bug label Apr 11, 2019
@ryantanaka ryantanaka self-assigned this Apr 11, 2019
@rafaelfsilva rafaelfsilva added this to the 1.4 milestone Apr 13, 2019
ryantanaka added a commit that referenced this issue Apr 21, 2019
@ryantanaka
#100 fixed bug where we can have two pstate timestamps set for some h…
1055749 
…ost at the same simulated time
ryantanaka added a commit that referenced this issue Apr 21, 2019
@ryantanaka
#100 updated tests
4f25d40
ryantanaka added a commit that referenced this issue Apr 22, 2019
@ryantanaka
#100 fix docs
4d54e53
@henricasanova
Copy link
Contributor

fixed by ryan and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryantanaka ryantanaka

Labels
bug
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
3 participants
@rafaelfsilva @henricasanova @ryantanaka