Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the Lemon library? #159

Closed
henricasanova opened this issue Apr 24, 2020 · 3 comments
Closed

Stop using the Lemon library? #159

henricasanova opened this issue Apr 24, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@henricasanova
Copy link
Contributor

Since the beginning, we've used the Lemon library for dealing with the DAG underlying the workflow. An alternative was the boost graph library, which the first student working on the project found too heavy-duty. But looking at examples, I think it could be straightforward to switch over the boost library. And since we already require boost, that would simply remove a dependency. Furthermore, lemon is a bit dead. Henri will likely be exploring this in a branch, perhaps even before the next release!

@rafaelfsilva
Copy link
Member

That would be great!

@henricasanova
Copy link
Contributor Author

I just pushed a fix to the master where lemon is no longer in the picture! I tested/valgrinded it on linux/MacOS. The boost GL isn't super easy to use, and the current implementation can likely be a bit improved (in terms of style).

If this works, we should remove lemon from all Docker instances!

@rafaelfsilva
Copy link
Member

Lemon has been removed from all Docker instances. I think we can close this issue.

@rafaelfsilva rafaelfsilva added this to the 1.6 milestone Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants