Skip to content

Commit

Permalink
Fix WRFDA 4DVAR compile for PGI 15.1 #265
Browse files Browse the repository at this point in the history
TYPE: bug fix

KEYWORDS: WRFDA, 4DVAR, compile, PGI

SOURCE: internal

DESCRIPTION OF CHANGES: Commit db7841c (Fix WRFDA reading of global attributes from netcdf input #258) introduced the subroutine "wrf_get_dom_ti_integer" to var/da/da_main/da_med_initialdata_input.inc. Because of naming conflicts with WRFPLUS, the code will not compile for 4DVAR when using certain PGI compilers (and perhaps others), even though GNU and Intel have no problem with it. This is solved by adding this subroutine to the script da_name_space.pl, which is part of the WRFDA build system that addresses this very problem: it renames certain subroutines when compiling for 4DVAR to avoid this conflict and allow the code to compile successfully.

LIST OF MODIFIED FILES:
M var/build/da_name_space.pl

TESTS CONDUCTED: WRFDA 4DVAR now compiles for PGI 15.1 (which is the compiler that exhibited the problem). WTF passes with flying colors.
(cherry picked from commit 49ec556)
  • Loading branch information
mkavulich committed Aug 15, 2017
1 parent 3747452 commit c7e9d11
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions var/build/da_name_space.pl
Original file line number Diff line number Diff line change
Expand Up @@ -192,4 +192,5 @@
wrf_get_dm_quilt_comm
wrf_dm_nestexchange_init
set_tiles
wrf_get_dom_ti_integer
###########################################################################################

0 comments on commit c7e9d11

Please sign in to comment.