Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA gen_be_v3 updates for cv_options=5 etc #1276

Merged
merged 13 commits into from
Aug 26, 2020

Conversation

jamiebresch
Copy link
Contributor

@jamiebresch jamiebresch commented Aug 24, 2020

TYPE: enhancement

KEYWORDS: WRFDA, gen_be_v3, cv_options=5

SOURCE: Jamie Bresch (NCAR)

DESCRIPTION OF CHANGES:
A collection of fixes and enhancements for gen_be_v3

  1. add multi-variate statistics capability for stream function, velocity potential, temperature and surface pressure
  2. bug fix for be_method=ENS with multiple valid dates
  3. add time_lag_ens option for calculating statistics from time lagged ensembles
  4. add a sample makefile that uses WRFDA-compiled lapack-lib.

LIST OF MODIFIED FILES:
M var/gen_be_v3/README.gen_be_v3
D var/gen_be_v3/compile_casper
D var/gen_be_v3/compile_cheyenne
M var/gen_be_v3/gen_be_v3.F90
A var/gen_be_v3/makefile
A var/gen_be_v3/util/combine_be_cv5.f90
A var/gen_be_v3/util/makefile

TESTS CONDUCTED:

  1. The updated code has been used by Taiwan's Central Weather Bureau and NCAR's Antarctic Mesoscale Prediction System.
  2. Jenkins tests all passed.

RELEASE NOTE: WRFDA gen_be_v3 is updated for cv_options=5 and ensemble applications. Please see var/gen_be_v3/README.gen_be_v3.

modified:   README.gen_be_v3
modified:   gen_be_v3.F90
new file:   util/combine_be_cv5.f90
Default is vertloc_opt=0, no vertical localization.
Set in namelist.gen_be_v3
&gen_be_nml
 vertloc_opt=1
to apply vertical localization using log-P algorithm.

modified:   var/gen_be_v3/gen_be_v3.F90
modified:   var/gen_be_v3/gen_be_v3.F90
1. allow the code to compile in either real8 or real4
2. trap improper number of processors

modified:   var/gen_be_v3/gen_be_v3.F90
1. move processor index calculation out of subroutine compute_pert
2. distribute the calculation of unbalanced fields and projecting to vertical modes

modified:   var/gen_be_v3/gen_be_v3.F90
1. psi should be interpolated to be on mass grids in order to have consistent dimensions as other variables
2. split checks for do_this_var(1:nvar) when nvar_all > nvar

modified:   var/gen_be_v3/gen_be_v3.F90
modified:   var/gen_be_v3/util/combine_be_cv5.f90
…essure.

modified:   var/gen_be_v3/gen_be_v3.F90
modified:   var/gen_be_v3/README.gen_be_v3
deleted:    var/gen_be_v3/compile_casper
deleted:    var/gen_be_v3/compile_cheyenne
modified:   var/gen_be_v3/gen_be_v3.F90
new file:   var/gen_be_v3/makefile
new file:   var/gen_be_v3/util/makefile
@jamiebresch jamiebresch requested a review from a team as a code owner August 24, 2020 21:05
@jamiebresch
Copy link
Contributor Author

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 755c227, requested by: jamiebresch for PR: #1276. For any query please send e-mail to David Gill.

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 19           18
Number of Builds       : 48           46
Number of Simulations  : 166           164        0
Number of Comparisons  : 105           104        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

modified:   var/gen_be_v3/README.gen_be_v3
modified:   var/gen_be_v3/makefile
Copy link
Contributor

@liujake liujake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge if ready.

@liujake
Copy link
Contributor

liujake commented Aug 25, 2020

@davegill Permission is changed for merge? I see 'Merge is blocked' for me.

@jamiebresch jamiebresch merged commit 847dd4d into wrf-model:develop Aug 26, 2020
hsbadr added a commit to hsbadr/WRF that referenced this pull request Aug 27, 2020
DA gen_be_v3 updates for cv_options=5 etc (wrf-model#1276)
@jamiebresch jamiebresch deleted the gen_be_v3 branch May 18, 2021 19:14
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: enhancement

KEYWORDS: WRFDA, gen_be_v3, cv_options=5

SOURCE: Jamie Bresch (NCAR)

DESCRIPTION OF CHANGES:
A collection of fixes and enhancements for gen_be_v3
1. add multi-variate statistics capability for stream function, velocity potential, temperature and surface pressure
2. bug fix for be_method=ENS with multiple valid dates
3. add time_lag_ens option for calculating statistics from time lagged ensembles
4. add a sample makefile that uses WRFDA-compiled lapack-lib.

LIST OF MODIFIED FILES:
M var/gen_be_v3/README.gen_be_v3
D var/gen_be_v3/compile_casper
D var/gen_be_v3/compile_cheyenne
M var/gen_be_v3/gen_be_v3.F90
A var/gen_be_v3/makefile
A var/gen_be_v3/util/combine_be_cv5.f90
A var/gen_be_v3/util/makefile

TESTS CONDUCTED:
1. The updated code has been used by Taiwan's Central Weather Bureau and NCAR's Antarctic Mesoscale Prediction System.
2. Jenkins tests all passed.

RELEASE NOTE: WRFDA gen_be_v3 is updated for cv_options=5 and ensemble applications. Please see var/gen_be_v3/README.gen_be_v3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants