-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regularized WSM6 and its TL/AD for 4DVar #1768
Conversation
This reverts commit 3ec9569.
This reverts commit 00155c1.
On branch wsm6_tlad modified: .github/CODEOWNERS new file: .gitmodules modified: Makefile modified: README modified: Registry/Registry.EM modified: Registry/Registry.EM_CHEM modified: Registry/Registry.EM_COMMON modified: Registry/Registry.EM_COMMON.var deleted: Registry/Registry.NMM
It appears that this adds a new scheme called wsm6s. Please say more about why this new scheme is needed and how it differs from WSM6, and add a description in the PR message. |
This passed regression tests:
|
@dudhia I will take care of this PR and add/request more info in PR message. |
I have issues to compile these code with gfortran with quite some error message below:
After I recovered the old code. It compiled successfully. |
@expertyang How about rename 'WSM6S' to 'WSM6R' meaning 'Regularized WSM6'. |
The regressions tests seem to be running slowly. Not sure why. |
I compiled Ok 'wrfplus' and 'wrfda-4dvar' on Cheyenne. wrfplus compilation took about 1-h with '-j 2' using gfortran+mpt. 4dvar compilation took about 10 min with '-j 4' using gofrtran+mpt. I am doing WRFDA regression tests now. |
The Jenkins tests have passed according to the email below (but not sure why this page is not updated - have contacted the relevant people and is waiting for an answer):
|
WRFDA regression tests passed and wrfplus & 4dvar with new wsm6r scheme succeeded. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Ready to merge.
@dudhia I'd like to merge this Today if you approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interaction with rest of model looks OK
TYPE: new feature KEYWORDS: WSM6, TL/AD, 4DVAR Description of Change: This PR adds a regularized version (i.e., change discontinuous functions to continuous functions) of WSM6 microphysics scheme (MP option 106, named as 'WSM6R') and its tangent linear and adjoint (TL/AD), which enables WRF-4DVar to run with ice-phase hydrometeor analysis variables. Note that the non-linear version of WSM6R is kept just for the code reference of deriving TL/AD, and it is NOT recommended to be used for the WRF model forecast. In addition, there is an improved handling of the file unit related to the background error covariance. SOURCE: Sen YANG, Deqin LI, Liqiang CHEN (Institute of Atmospheric Environment, China Meteorological Administration, Shenyang) LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M Registry/registry.var M Registry/registry.wrfplus M main/depend.common M phys/Makefile M phys/module_microphysics_driver.F A phys/module_mp_wsm6s.F M var/da/da_setup_structures/da_scale_background_errors.inc M var/da/da_setup_structures/da_setup_be_regional.inc M var/da/da_transfer_model/da_transfer_wrftltoxa.inc M var/da/da_transfer_model/da_transfer_wrftltoxa_adj.inc M var/da/da_transfer_model/da_transfer_xatowrftl.inc M var/da/da_transfer_model/da_transfer_xatowrftl_adj.inc M wrftladj/Makefile M wrftladj/depend.wrftladj M wrftladj/module_microphysics_driver_ad.F M wrftladj/module_microphysics_driver_tl.F A wrftladj/module_mp_wsm6s_ad.F A wrftladj/module_mp_wsm6s_tl.F M wrftladj/solve_em_ad.F M wrftladj/solve_em_tl.F TESTS CONDUCTED: 1. Jenkins tests all passed; 2. WRFDA regression test passed on Cheyenne; 3. wrfplus and 4dvar tests succeeded using mp_physics & mp_physics_ad=106. RELEASE NOTE: Add a regularized version of WSM6 and its TL/AD for 4DVar with ice-phase hydrometeor analysis variables. Yang, S., D. Q. Li, L. Q. Chen, Z. Liu, X.-Y. Huang, and X. Pan, 2022: The regularized WSM6 microphysical scheme and its validation in WRF 4D-Var. Adv. Atmos. Sci., in press.
TYPE: new feature
KEYWORDS: WSM6, TL/AD, 4DVAR
Description of Change:
This PR adds a regularized version (i.e., change discontinuous functions to continuous functions) of WSM6 microphysics scheme (MP option 106, named as 'WSM6R') and its tangent linear and adjoint (TL/AD), which enables WRF-4DVar to run with ice-phase hydrometeor analysis variables. Note that the non-linear version of WSM6R is kept just for the code reference of deriving TL/AD, and it is NOT recommended to be used for the WRF model forecast. In addition, there is an improved handling of the file unit related to the background error covariance.
SOURCE: Sen YANG, Deqin LI, Liqiang CHEN (Institute of Atmospheric Environment, China Meteorological Administration, Shenyang)
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M Registry/registry.var
M Registry/registry.wrfplus
M main/depend.common
M phys/Makefile
M phys/module_microphysics_driver.F
A phys/module_mp_wsm6s.F
M var/da/da_setup_structures/da_scale_background_errors.inc
M var/da/da_setup_structures/da_setup_be_regional.inc
M var/da/da_transfer_model/da_transfer_wrftltoxa.inc
M var/da/da_transfer_model/da_transfer_wrftltoxa_adj.inc
M var/da/da_transfer_model/da_transfer_xatowrftl.inc
M var/da/da_transfer_model/da_transfer_xatowrftl_adj.inc
M wrftladj/Makefile
M wrftladj/depend.wrftladj
M wrftladj/module_microphysics_driver_ad.F
M wrftladj/module_microphysics_driver_tl.F
A wrftladj/module_mp_wsm6s_ad.F
A wrftladj/module_mp_wsm6s_tl.F
M wrftladj/solve_em_ad.F
M wrftladj/solve_em_tl.F
TESTS CONDUCTED:
RELEASE NOTE: Add a regularized version of WSM6 and its TL/AD for 4DVar with ice-phase hydrometeor analysis variables.
Yang, S., D. Q. Li, L. Q. Chen, Z. Liu, X.-Y. Huang, and X. Pan, 2022: The regularized WSM6 microphysical scheme and its validation in WRF 4D-Var. Adv. Atmos. Sci., in press.