HAILCAST bug fixes: tiling, non-SI units #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islas
reviewed
Jun 7, 2023
islas
reviewed
Jun 7, 2023
weiwangncar
reviewed
Jun 9, 2023
|
@adams-selin Regression tests now have passed: |
islas
reviewed
Jun 9, 2023
dudhia
approved these changes
Jul 5, 2023
|
@islas Are you ok with this PR? Can you approve, if it is ok? |
islas
approved these changes
Jul 19, 2023
6 tasks
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: HAILCAST, tiling issues, undefined variables SOURCE: Becky Adams-Selin DESCRIPTION OF CHANGES: Problem: When running using tiling/quilted processes, the haildtacttime variable was being reset by every tile, thereby only activating HAILCAST to run on a single tile. Also, the RWA_new calculation can sometimes be undefined if the cloud base index is not set before the loop, and some SI/non-SI unit conversions were not handled correctly in the HEATBUD subroutine. Solution: The haildtacttime variable was changed to an gridded variable so could be set individually by gridpoint. Cloud base index definition added before the loop. SI/non-SI unit conversions fixed. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M phys/module_diag_hailcast.F TESTS CONDUCTED: Modifications fixed problem, and are currently used in operational HRRR v4.0. The Jenkins tests are all passing. RELEASE NOTE: HAILCAST quilted processes/tiling and a few other bug fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: HAILCAST, tiling issues, undefined variables
SOURCE: Becky Adams-Selin
DESCRIPTION OF CHANGES:
Problem:
When running using tiling/quilted processes, the haildtacttime variable was being reset by every tile, thereby only activating HAILCAST to run on a single tile. Also, the RWA_new calculation can sometimes be undefined if the cloud base index is not set before the loop, and some SI/non-SI unit conversions were not handled correctly in the HEATBUD subroutine.
Solution:
The haildtacttime variable was changed to an gridded variable so could be set individually by gridpoint. Cloud base index definition added before the loop. SI/non-SI unit conversions fixed.
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M phys/module_diag_hailcast.F
TESTS CONDUCTED:
RELEASE NOTE: HAILCAST quilted processes/tiling and a few other bug fixes.