Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for erroneous syntax in dyn_em/module_first_rk_step_part1.F #1976

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

islas
Copy link
Collaborator

@islas islas commented Jan 5, 2024

TYPE: bug fix

KEYWORDS: syntax

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Wrong Fortran syntax most likely being corrected by standard.exe

Solution:
Fix the syntax error

LIST OF MODIFIED FILES:
M dyn_em/module_first_rk_step_part1.F

RELEASE NOTE:
Bug fix for erroneous syntax in dyn_em/module_first_rk_step_part1.F

@islas
Copy link
Collaborator Author

islas commented Jan 5, 2024

This should normally be based on master for a bug fix, but is required by #1896 to properly work

Copy link
Collaborator

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. From the Fortran 2003 standard, 3.3.1.2 Free form statement continuation:

If a noncharacter context is to be continued, an “&” shall be the last nonblank character on the line,
or the last nonblank character before an “!”. There shall be a later line that is not a comment; the
statement is continued on the next such line. If the first nonblank character on that line is an “&”, the
statement continues at the next character position following that “&”; otherwise, it continues with the
first character position of that line.

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar merged commit cb77ee1 into wrf-model:develop Jan 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants