Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure alloc space calls into simpler smaller files #2068

Merged
merged 16 commits into from
Sep 26, 2024

Conversation

islas
Copy link
Collaborator

@islas islas commented Jun 14, 2024

TYPE: enhancement

KEYWORDS: intel, compilation, llvm, memory

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The Intel oneAPI compilers (and others like nvhpc) struggle with some of the larger (15k+ lines of code) files within WRF. This causes intense memory usage that is not often available to the average user not in a resource-rich environment. This often limits compilation to single threaded if even possible or to a dedicated environment with enough memory if available. If neither of those is available to a user, they will be unable to use these configurations entirely.

Solution:
This PR focuses on the module_alloc_space* sections of code to reduce their individual file size to manageable levels. They are instead broken out into many smaller files as external subroutines, not requiring a wrapper module to house the subroutine call. The files are now fully generated source code from the registry, with the calls to the subroutines also being generated as well. This also makes it relatively easy to change the number of files generated from a source code perspective. Build rules would need to be modified accordingly as seen in these changes.

TESTS CONDUCTED:
Attached to this PR are plots of the respective effects of theses changes. Changes were tested with intel and gcc compilers, but only intel memory usage is shown as it exacerbates the memory usage issue.

@islas islas requested review from a team as code owners June 14, 2024 22:31
@islas
Copy link
Collaborator Author

islas commented Jun 14, 2024

Highlighted is the region during compilation which memory usage spikes that this PR addresses (module_alloc_space*) before these changes take place :
pre_alloc

This usage is then dropped when using this PR's edits :
post_alloc_split

Zooming in we can now see that allocs_ comprise a number of smaller compilation units :
post_alloc_split_zoom

@weiwangncar
Copy link
Collaborator

@islas This PR has not passed Jenkins tests at this time. The failed test is with the DA compilation.

@weiwangncar
Copy link
Collaborator

I tested code before and after this PR, and model produces identical results in my test. Also with 4 processors, the compile time is about 12 minutes!

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

weiwangncar
weiwangncar previously approved these changes Aug 8, 2024
@mgduda mgduda self-requested a review September 19, 2024 22:08
Copy link
Collaborator

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions. Those aside, this looks good to me.

var/build/makefile Outdated Show resolved Hide resolved
var/build/depend.txt Outdated Show resolved Hide resolved
var/build/depend.txt Outdated Show resolved Hide resolved
@mgduda mgduda self-requested a review September 24, 2024 19:16
@islas islas merged commit ed585bd into wrf-model:release-v4.6.1 Sep 26, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants