Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake check system for underscore requirements between C and Fortran #2091

Open
wants to merge 18 commits into
base: release-v4.6.1
Choose a base branch
from
Open

CMake check system for underscore requirements between C and Fortran #2091

wants to merge 18 commits into from

Commits on May 31, 2024

  1. Force fail on genexp in defines

    @islas
    islas committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5b024c0 View commit details
    Browse the repository at this point in the history

  2. Rewrite the defines to not use genexp

    @islas
    islas committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7c6e773 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Move internal flags and compile definitions to variables rather than … 

    …applied globablly
    @islas
    islas committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    980aca8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Make sure hydro gets all the flags similar to original cmake build

    @islas
    islas committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6b9d27e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Prepare cmake build to not have core selection

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4dda109 View commit details
    Browse the repository at this point in the history

  2. Make sure appropriate selection of option for non-ARW cores

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bee8ddd View commit details
    Browse the repository at this point in the history

  3. Shortcut selections for other cores

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4e30de1 View commit details
    Browse the repository at this point in the history

  4. Generalize the sanitization logic for stanzas

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5598e7c View commit details
    Browse the repository at this point in the history

  5. Create properties for flag and defines organization

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    96930f5 View commit details
    Browse the repository at this point in the history

  6. Fine-tuned control of compile flags

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0203d61 View commit details
    Browse the repository at this point in the history

  7. Don't force specific define able to come from stanza

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    86c3707 View commit details
    Browse the repository at this point in the history

  8. Allow for regular defines to be passed in

    @islas
    islas committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1769477 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Reduce configuration check logic by using try_* functions

    @islas
    islas committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    812acda View commit details
    Browse the repository at this point in the history

  2. Purge underscore defs from stanza reading

    @islas
    islas committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b1a8fa1 View commit details
    Browse the repository at this point in the history

  3. Fix default try run setting

    @islas
    islas committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    41df958 View commit details
    Browse the repository at this point in the history

  4. Adjust message text for failed checks

    @islas
    islas committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    64a9e28 View commit details
    Browse the repository at this point in the history

  5. Add underscore check

    @islas
    islas committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    55656fe View commit details
    Browse the repository at this point in the history

  6. Incorporate underscore check into definitions

    @islas
    islas committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b263d5f View commit details
    Browse the repository at this point in the history