Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github pull request template #256

Merged
merged 2 commits into from
May 5, 2017

Conversation

mkavulich
Copy link
Contributor

TYPE: text only

KEYWORDS: github, pull request template

SOURCE: internal

DESCRIPTION OF CHANGES: I recently learned that Github supports the capability to store a pull request template message as a hidden file in the source code.

Currently the template for pull request messages (which become the git log messages we see after the pull request is moved) is stored in the source code under tools/commit_form.txt. This will still be kept for reference, but now a condensed form of this message (with a link to further information) will automatically appear in the text box when you go to open a new pull request.

LIST OF MODIFIED FILES:
A .github/PULL_REQUEST_TEMPLATE

TESTS CONDUCTED: Added this template to my fork and attempted to open a new pull request to the master of my fork, confirmed the expected behavior that the text appeared automatically in the text box!

Copy link
Contributor

@davegill davegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by WRF Dev

@mkavulich mkavulich merged commit bae318b into wrf-model:master May 5, 2017
@mkavulich mkavulich deleted the pull_request_template branch September 19, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants