Add packaging in registry.var for WRFDA derived type variables #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebresch
force-pushed
the
wrfda_package2
branch
from
a03d484
to
7de5fca
Compare
modified: Registry/registry.var modified: tools/gen_allocs.c modified: tools/gen_scalar_indices.c modified: tools/protos.h modified: var/da/da_main/da_wrfvar_init2.inc modified: var/da/da_radar/da_radar.f90 modified: var/da/da_radar/da_transform_xtoy_radar.inc modified: var/da/da_radar/da_transform_xtoy_radar_adj.inc modified: var/da/da_radiance/da_crtm.f90 modified: var/da/da_radiance/da_transform_xtoy_crtm.inc modified: var/da/da_radiance/da_transform_xtoy_crtm_adj.inc
jamiebresch
force-pushed
the
wrfda_package2
branch
from
7de5fca
to
9ab0b2b
Compare
mkavulich
approved these changes
Aug 11, 2017
davegill
added
Approved for release branch
and removed
Proposed for release branch
labels
mkavulich
added
Applied to release branch
and removed
Approved for release branch
labels
mkavulich
pushed a commit
that referenced
this pull request
Aug 15, 2017
TYPE: enhancement KEYWORDS: WRFDA, registry.var, package, derived type SOURCE: Jamie Bresch (NCAR) DESCRIPTION OF CHANGES: A few C programs in tools are modified to allow packaging for derived types that WRFDA use. Main changes are in registry.var. Changes in var/da files are for complementing the registry changes. This reduces the 3DVAR memory usage by another ~15-20%. This PR changes the section of code for ARW's fdob derived type in inc/allocs.inc. But note that fdob is not packaged both before and after the change. LIST OF MODIFIED FILES: M Registry/registry.var M tools/gen_allocs.c M tools/gen_scalar_indices.c M tools/protos.h M var/da/da_main/da_wrfvar_init2.inc M var/da/da_radar/da_radar.f90 M var/da/da_radar/da_transform_xtoy_radar.inc M var/da/da_radar/da_transform_xtoy_radar_adj.inc M var/da/da_radiance/da_crtm.f90 M var/da/da_radiance/da_transform_xtoy_crtm.inc M var/da/da_radiance/da_transform_xtoy_crtm_adj.inc TESTS CONDUCTED: 1. WRFDA regtests on cheyenne with intel/17.0.1 passed. 2. WTF_v03.08 on yellowstone with gnu/4.9.2 and intel/12.1.5 passed. (cherry picked from commit c7405bb)
mkavulich
pushed a commit
that referenced
this pull request
Aug 24, 2017
TYPE: enhancement KEYWORDS: WRFDA, registry.var, package, derived type SOURCE: Jamie Bresch (NCAR) DESCRIPTION OF CHANGES: A few C programs in tools are modified to allow packaging for derived types that WRFDA use. Main changes are in registry.var. Changes in var/da files are for complementing the registry changes. This reduces the 3DVAR memory usage by another ~15-20%. This PR changes the section of code for ARW's fdob derived type in inc/allocs.inc. But note that fdob is not packaged both before and after the change. LIST OF MODIFIED FILES: M Registry/registry.var M tools/gen_allocs.c M tools/gen_scalar_indices.c M tools/protos.h M var/da/da_main/da_wrfvar_init2.inc M var/da/da_radar/da_radar.f90 M var/da/da_radar/da_transform_xtoy_radar.inc M var/da/da_radar/da_transform_xtoy_radar_adj.inc M var/da/da_radiance/da_crtm.f90 M var/da/da_radiance/da_transform_xtoy_crtm.inc M var/da/da_radiance/da_transform_xtoy_crtm_adj.inc TESTS CONDUCTED: 1. WRFDA regtests on cheyenne with intel/17.0.1 passed. 2. WTF_v03.08 on yellowstone with gnu/4.9.2 and intel/12.1.5 passed. (cherry picked from commit c7405bb) (cherry picked from commit cf876ee)
jjguerrette
pushed a commit
to jjguerrette/WRF-public
that referenced
this pull request
Sep 12, 2018
by requiring cloud_cv_options that match packaging defined in registry.var for xa%qrn, xa%qcw, xa%qci, xa%qsn, and xa%qgr This bugfix is connected to PR wrf-model#283 from 11 AUG 2017. The array bounds error this avoids occurs when mp_physics ~= [0, 98] and cloud_cv_options==0. With "debug" build of WRFDA and without fix, the end of rsl.error.0000: forrtl: severe (408): fort: (2): Subscript wrf-model#1 of the array QCW has value 2 which is greater than the upper bound of 1 Image PC Routine Line Source da_wrfvar.exe 00000000060CF996 Unknown Unknown Unknown da_wrfvar.exe 00000000017EDB3B da_transfer_model 2224 da_transfer_model.f da_wrfvar.exe 00000000018A4263 da_transfer_model 3399 da_transfer_model.f da_wrfvar.exe 00000000004C5D92 da_wrfvar_top_mp_ 3675 da_wrfvar_top.f da_wrfvar.exe 00000000004B0699 da_wrfvar_top_mp_ 2779 da_wrfvar_top.f da_wrfvar.exe 00000000004B0559 da_wrfvar_top_mp_ 2749 da_wrfvar_top.f da_wrfvar.exe 0000000000459863 MAIN__ 34 da_wrfvar_main.f da_wrfvar.exe 0000000000405C1E Unknown Unknown Unknown libc-2.19.so 00002AAAAB7E5B25 __libc_start_main Unknown Unknown da_wrfvar.exe 0000000000405B29 Unknown Unknown Unknown Changes to be committed: modified: var/da/da_transfer_model/da_transfer_xatowrf.inc
jjguerrette
pushed a commit
that referenced
this pull request
Sep 13, 2018
TYPE: bug fix KEYWORDS: moist, analysis update SOURCE: Internal (JJG) DESCRIPTION OF CHANGES: xatowrf now requires cloud_cv_options that match packaging defined in registry.var for xa%qrn, xa%qcw, xa%qci, xa%qsn, and xa%qgr. This bugfix is connected to PR #283 from 11 AUG 2017 (c7405bb#diff-fe8b020143d32583d82b945e2bd66f50) The array bounds error this avoids occurs when mp_physics ~= [0, 98] and cloud_cv_options==0. LIST OF MODIFIED FILES: M var/da/da_transfer_model/da_transfer_xatowrf.inc TESTS CONDUCTED: The following error at the end of rsl.error.0000 is avoided with this fix when "debug" build is used for WRFDA: >``forrtl: severe (408): fort: (2): Subscript #1 of the array QCW has value 2 which is greater than the upper bound of 1`` > >``Image PC Routine Line Source da_wrfvar.exe 00000000060CF996 Unknown Unknown Unknown da_wrfvar.exe 00000000017EDB3B da_transfer_model 2224 da_transfer_model.f da_wrfvar.exe 00000000018A4263 da_transfer_model 3399 da_transfer_model.f da_wrfvar.exe 00000000004C5D92 da_wrfvar_top_mp_ 3675 da_wrfvar_top.f da_wrfvar.exe 00000000004B0699 da_wrfvar_top_mp_ 2779 da_wrfvar_top.f da_wrfvar.exe 00000000004B0559 da_wrfvar_top_mp_ 2749 da_wrfvar_top.f da_wrfvar.exe 0000000000459863 MAIN__ 34 da_wrfvar_main.f da_wrfvar.exe 0000000000405C1E Unknown Unknown Unknown libc-2.19.so 00002AAAAB7E5B25 __libc_start_main Unknown Unknown da_wrfvar.exe 0000000000405B29 Unknown Unknown Unknown`` The WRFDA Regression test was not run. The changes are minor and fix the known bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: WRFDA, registry.var, package, derived type
SOURCE: Jamie Bresch (NCAR)
DESCRIPTION OF CHANGES:
A few C programs in tools are modified to allow packaging for
derived types that WRFDA use.
Main changes are in registry.var.
Changes in var/da files are for complementing the registry changes.
This reduces the 3DVAR memory usage by another ~15-20%.
This PR changes the section of code for ARW's fdob derived type in inc/allocs.inc.
But note that fdob is not packaged both before and after the change.
LIST OF MODIFIED FILES:
M Registry/registry.var
M tools/gen_allocs.c
M tools/gen_scalar_indices.c
M tools/protos.h
M var/da/da_main/da_wrfvar_init2.inc
M var/da/da_radar/da_radar.f90
M var/da/da_radar/da_transform_xtoy_radar.inc
M var/da/da_radar/da_transform_xtoy_radar_adj.inc
M var/da/da_radiance/da_crtm.f90
M var/da/da_radiance/da_transform_xtoy_crtm.inc
M var/da/da_radiance/da_transform_xtoy_crtm_adj.inc
TESTS CONDUCTED: