Fix for SEVIRI and IASI radiance assimilation with more than one .bufr file #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to deallocate the dynamically allocated arrays within the bufrfile do loop. Fix from Dr. Thomas Schwitalla, University of Hohenheim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: WRFDA, SEVIRI, IASI, radiance, bufr
SOURCE: Dr. Thomas Schwitalla, University of Hohenheim
DESCRIPTION OF CHANGES: There were some missing/misplaced deallocation statements in the subroutines for reading IASI and SEVIRI BUFR files which resulted in errors when trying to read two different files of the same observation type for these instruments. The errors were due to attempting to allocate already-allocated arrays. Moving the deallocate statements inside the file read loop, as well as adding a few more necessary deallocation statements, fix this error.
LIST OF MODIFIED FILES:
M var/da/da_radiance/da_read_obs_bufriasi.inc
M var/da/da_radiance/da_read_obs_bufrseviri.inc
TESTS CONDUCTED: Created a new regression test for 4DVAR reading two files at once, both for IASI and SEVIRI. The test failed as expected before the fix, and now passes. For GNU the test runs successfully, for Intel there is still a failure later on in the assimilation process that still needs to be resolved (likely unrelated to this issue). Other tests all still pass as expected.