Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate 3 slightly different batch job dockerfiles to 1 #645

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Mar 4, 2025

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

We build 3 slightly different images depending on the type of job to be run
Also, there's bug GTC-2895 (discrete symbology doesn't work)

Issue Number: GTC-2895

What is the new behavior?

  • Consolidate the 3 dockerfiles to 1
  • Upgrade GDAL and tippecanoe while at it (the first of which addresses the bug in GTC-2895)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dmannarino dmannarino marked this pull request as ready for review March 4, 2025 17:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (4032305) to head (242a619).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #645   +/-   ##
========================================
  Coverage    77.70%   77.70%           
========================================
  Files          142      142           
  Lines         6516     6516           
========================================
  Hits          5063     5063           
  Misses        1453     1453           
Flag Coverage Δ
unittests 77.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmannarino dmannarino marked this pull request as draft March 10, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants