Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: from_solis parse more metadata #973

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: from_solis parse more metadata #973

wants to merge 1 commit into from

Conversation

ddkohler
Copy link
Contributor

Changes

Checklist

  • tests (and add datasets for tests)
  • handle rotations, once understood
  • update from_solis documentation (if needed)
  • updated CHANGELOG.md
  • tests pass

@ksunden
Copy link
Member

ksunden commented Sep 30, 2021

@ddkohler is there desire to finish this PR?

@ddkohler
Copy link
Contributor Author

@ksunden I still think it's a worthwhile project, but this is not my focus right now.

@ksunden ksunden mentioned this pull request Oct 25, 2021
Merged
4 tasks
@ddkohler ddkohler marked this pull request as draft August 31, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

@kameyer226 kameyer226 Awaiting requested review from kameyer226 kameyer226 is a code owner

@ksunden ksunden Awaiting requested review from ksunden ksunden is a code owner

@untzag untzag Awaiting requested review from untzag untzag is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddkohler @ksunden