forked from Fintan-contents/mobile-app-crib-notes
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️: Update to Node 20 #1290
Draft
sinho-lee
wants to merge
6
commits into
master
Choose a base branch
from
feature/update-node-version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
⬆️: Update to Node 20 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in-a-paddy
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙅 GitHub ActionsとAzure Pipelinesで利用するNode.jsのバージョンも修正をお願いします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
chore
Other changes that don't modify src or test files.
ci
Changes to CI configuration files and scripts (GitHub Actions etc.)
dependencies
Pull requests that update a dependency file
doc
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What's done
開発環境の構築
ページのNodeバージョンを修正 (対応Commit: c2da102)Expo SDK 49アップグレード
ページのNodeバージョンを追記 (対応Commit: ee66363)Tests
npm
に関するコマンドの実行npm run test
npm ci
npm run prebuild
npm run pod-install
Other (messages to reviewers, concerns, etc.)
なし