Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new indexing strategy to support case insensitivity #6166

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sachin-Mamoru
Copy link
Contributor

@Sachin-Mamoru Sachin-Mamoru commented Dec 1, 2024

Proposed changes in this pull request

When should this PR be merged

  • Check migration impact if we drop primary keys. Else we can auto-generate a primary key.
  • And if a foreign key references the primary key what should be the process to drop it?
  • Check the impact of the unique constrain and unique index possibility of having null values
  • Add specific migration docs for these changes
  • Newly added index checks the usage of queries and analyses the order and all
CREATE INDEX IDX_AT_CK_AU_LO ON IDN_OAUTH2_ACCESS_TOKEN(CONSUMER_KEY_ID, LOWER(AUTHZ_USER), TOKEN_STATE, USER_TYPE);
CREATE INDEX IDX_AT_AU_TID_UD_TS_CKID_LO ON IDN_OAUTH2_ACCESS_TOKEN(LOWER(AUTHZ_USER), TENANT_ID, USER_DOMAIN, TOKEN_STATE, CONSUMER_KEY_ID);
CREATE INDEX IDX_AT_AU_CKID_TS_UT_LO ON IDN_OAUTH2_ACCESS_TOKEN(LOWER(AUTHZ_USER), CONSUMER_KEY_ID, TOKEN_STATE, USER_TYPE);

Copy link

sonarqubecloud bot commented Dec 1, 2024

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.80%. Comparing base (366a820) to head (ff14948).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6166      +/-   ##
============================================
+ Coverage     44.64%   44.80%   +0.16%     
- Complexity    13474    13591     +117     
============================================
  Files          1580     1604      +24     
  Lines         98826    99157     +331     
  Branches      16043    16070      +27     
============================================
+ Hits          44124    44431     +307     
- Misses        48092    48097       +5     
- Partials       6610     6629      +19     
Flag Coverage Δ
unit 26.94% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sachin-Mamoru Sachin-Mamoru marked this pull request as draft December 1, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant