Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve System API registration behaviour #6259

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shashimalcse
Copy link
Contributor

@shashimalcse shashimalcse commented Jan 6, 2025

Proposed changes in this pull request

Due to limitations in the current implementation, whenever a new scope is added to an API resource, in order to update the scope in the DB, a duplicate API resource entry should be added to the system-api-resource.xml with the new scopes.

In this PR, we improve the current implementation to allow updating API resources without duplicate entries.

Related Issues

Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.66%. Comparing base (2befdf7) to head (06fe967).
Report is 120 commits behind head on master.

Files with missing lines Patch % Lines
...i/resource/mgt/util/APIResourceManagementUtil.java 91.17% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6259      +/-   ##
============================================
+ Coverage     45.63%   45.66%   +0.03%     
- Complexity    14076    14317     +241     
============================================
  Files          1631     1633       +2     
  Lines        101500   103884    +2384     
  Branches      17884    18541     +657     
============================================
+ Hits          46316    47440    +1124     
- Misses        48480    49609    +1129     
- Partials       6704     6835     +131     
Flag Coverage Δ
unit 28.47% <91.42%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant