Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the validation for integer type with empty values. #421

Merged

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Jan 27, 2025

Purpose

  • $subject

Related issues

Approach

  • With this PR, we are skipping the validations for integers when we recieve a empty string("") that means users can clear the integer value.
  • At the moment if we receive a empty string then it will give 500 error when it tries to decode.
  • With this fix, it will skip the value pass point and validation point for integer type when value equals to "".
  • Note: When we set the value to "" in attribute this will not return to FE and therefore behaviour will not change as previous.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.12%. Comparing base (e3cca00) to head (ac03018).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #421      +/-   ##
============================================
+ Coverage     28.57%   30.12%   +1.55%     
- Complexity      921      979      +58     
============================================
  Files           133      134       +1     
  Lines         13041    13203     +162     
  Branches       2512     2537      +25     
============================================
+ Hits           3726     3978     +252     
+ Misses         8832     8716     -116     
- Partials        483      509      +26     
Flag Coverage Δ
unit 29.29% <100.00%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12988399007
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12988399007

@mpmadhavig mpmadhavig merged commit 1ca1ead into wso2:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants