[development] Update webpack rewrite logic to facilitate pre-auth in local development #7598
+90
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7598 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 42 42
Lines 939 939
Branches 230 238 +8
=======================================
Hits 393 393
- Misses 502 546 +44
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. |
| const DEBUG_ENABLED: boolean = false; | ||
| const DEBUG_LOG_KEY: string = "webpack-dev-server"; | ||
| // eslint-disable-next-line @typescript-eslint/typedef, no-console | ||
| const log = console.log; |
There was a problem hiding this comment.
If we directly assign console, we won't need a eslint disable comment here 😉
Suggested change
| const log = console.log; | |
| const logger = console; |
Comment on lines
+723
to
+731
| let matchFound: boolean = false; | ||
|
|
||
| for (const pattern of patterns) { | ||
| if (pattern.test(pathWithoutQuery) && query.code) { | ||
| matchFound = true; | ||
|
|
||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
We can use .some instead.
const matchFound = patterns.some(pattern => pattern.test(pathWithoutQuery) && query.code);
pavinduLakshan
changed the title
|
Much needed improvement btw 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks