Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where do we get targets from? #8

Open
gregmacfarlane opened this issue Mar 17, 2016 · 4 comments
Open

Where do we get targets from? #8

gregmacfarlane opened this issue Mar 17, 2016 · 4 comments

Comments

@gregmacfarlane
Copy link
Contributor

Would it be better to code default targets into the package, or do we expect every jurisdiction would have its own targets?

gregmacfarlane added a commit that referenced this issue Mar 17, 2016
These are the volumes in Asheville. Perhaps we need other levels? Related to #8
@dkyleward
Copy link
Contributor

I'd say code our own targets into the package. If we run into an issue, perhaps we could let the project code modify the target?

@gregmacfarlane
Copy link
Contributor Author

I think it would be really elegant to have default targets in here already (which we do), but to easily override them with local info. We'll need to think through this and do it carefully.

@gregmacfarlane
Copy link
Contributor Author

I think a good thing to do would be to create target tables, sort of like the mdd object already has.

mdd <- dplyr::data_frame(
  volume = c(1000, 2500, 5000, 10000, 25000, 50000, 70000),
  mdd = c(0.9, 0.7, 0.5, 0.35, 0.25, 0.2, 0.10) * 100
)

mdd
## Source: local data frame [7 x 2]

##  volume   mdd
##   (dbl) (dbl)
## 1   1000    90
## 2   2500    70
## 3   5000    50
## 4  10000    35
## 5  25000    25
## 6  50000    20
## 7  70000    10

These become data objects transported with the package, but the user can supply their own if they have it.

@4Step
Copy link

4Step commented Mar 30, 2016

Lets make all targets (not just volume) as user inputs. Additionally writing totals should be made a user input as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants