Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot overlappogram configuration #31

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

jacobdparker
Copy link
Collaborator

Adding instrument design for new MOXSI design that has a dispersed slot channel

@wtbarnes wtbarnes changed the title Getting Slotty Add slot overlappogram configuration Jan 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (9662e94) 65.48% compared to head (0660419) 66.85%.
Report is 1 commits behind head on main.

Files Patch % Lines
mocksipipeline/instrument/design.py 26.08% 17 Missing ⚠️
mocksipipeline/instrument/optics/aperture.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   65.48%   66.85%   +1.36%     
==========================================
  Files          14       15       +1     
  Lines         649      724      +75     
==========================================
+ Hits          425      484      +59     
- Misses        224      240      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes merged commit fc57e1e into wtbarnes:main Jan 23, 2024
11 checks passed
@jacobdparker jacobdparker deleted the slotty_moxsi branch January 26, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants