Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refreshInterval less than 1 second #1103

Closed
poetaman opened this issue Sep 7, 2021 · 5 comments
Closed

refreshInterval less than 1 second #1103

poetaman opened this issue Sep 7, 2021 · 5 comments
Labels
💥 feature "Good luck, you're gonna need it."

Comments

@poetaman
Copy link

poetaman commented Sep 7, 2021

I know this might sound crazy for a dashboard, but some modules can happily take a refresh rate of less than 1 second. It can be a stopwatch for instance...

@noxer
Copy link
Contributor

noxer commented Oct 5, 2021

Maybe this could be implemented by adding a refreshUnit field to the common config and then multiplying refreshInterval with it.

Basically a string that will be parsed into a duration. When the unit is not set or can't be parsed, '1s' is assumed, leading to the default behavior. Otherwise the two values are multiplied.

Otherwise we could use a float to handle the config and rewriting the scheduler to convert it into nanoseconds.

Both ways shouldn't require anyone to touch their config.

@senorprogrammer
Copy link
Collaborator

senorprogrammer commented Oct 9, 2021

Before tackling this problem at all, I'd like to see a few valid use-cases for a faster refresh rate that have a practical application. I'm not yet convinced this is a problem that needs to be solved.

@poetaman
Copy link
Author

@senorprogrammer I commented there: #1120 (comment)

@senorprogrammer
Copy link
Collaborator

senorprogrammer commented Oct 30, 2021

Solved by @ResamVi. Configurations now support an optional time unit, ie: 50ms, 5s, etc. A lone integer (ie: 20) will still be interpreted as seconds.

@poetaman
Copy link
Author

@senorprogrammer @ResamVi Thanks, works well!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 feature "Good luck, you're gonna need it."
Development

No branches or pull requests

3 participants