Refreshintervals less than one second #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1103
In continuation of #1120
This feature made
wtf
hang up and couldn't be exit withctrl+c
:So what happened is that the
textfile
module is not using theSchedule
function like every other module does.Instead it deploys it's own scheduling logic in
watchForFileChanges
because - unlike every other module - it refreshes on file changes instead of regular intervals.That logic however didn't listen to
ctrl+c
and wouldn't properly exit.So I simply added the below case for it to work. Now WTF properly exits.
Changing from
int
totime.Duration
somehow unearthed this problem and I don't really know why.I've changed all instances of
refreshInterval int
torefreshInterval time.Duration
in every module to keep it completely consistent and not have any loose ends open.