put temporary data file in the same directory as the data file itself #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make shutil.move use rename, which is atomic, avoiding losing data when interweaving writes happen. This will close wting#358.
lilydjwg
changed the title
wting
force-pushed
the
master
branch
10 times, most recently
from
6da975f to
8eace44
Compare
|
Oops, I missed this PR. I reverted my patch and merged this PR into 8fffbad so that credit is properly attributed. Thanks for opening up this PR and cleaning up afterwards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make shutil.move use rename, which is atomic, avoiding
losing data when interweaving writes happen.
This will close #358 and should fix #391.