Add method support #381
Add method support #381
Conversation
# Conflicts: # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/argument/ArgumentResolver.kt # app/aem/core/src/test/groovy/com/cognifide/apm/core/grammar/ArgumentResolverTest.groovy # app/aem/core/src/test/groovy/com/cognifide/apm/core/grammar/ScriptRunnerTest.groovy # app/aem/core/src/test/resources/define.apm
| methodDefinitions.put(methodDefinition.getName(), methodDefinition); | ||
| } | ||
|
|
||
| protected final void unbindMethodDefinition(MethodDefinition methodDefinition) { |
There was a problem hiding this comment.
hmmm unbind method will be called by name convention? or should be annotated as well?
| Resource resource = resourceResolver.getResource(path); | ||
| List<ApmString> values = StreamSupport.stream(resource.getChildren().spliterator(), false) | ||
| .filter(this::isValidResource) | ||
| .map(Resource::getName) |
There was a problem hiding this comment.
how about accepting optionally nameRegex as second parameter?
I believe checking ":" will be too naive and must be configurable
| for (Resource market : resource.getChildren()) { | ||
| if (isPageResource(market)) { | ||
| Map<String, ApmType> value = new HashMap<>(); | ||
| value.put("code", new ApmString(market.getName())); |
There was a problem hiding this comment.
code? please ensure to use here strict Adobe/AEM nomenclature / a name typically used by Adobe to describe nodes at that level
There was a problem hiding this comment.
if nodes with en_US (another form of structuring AEM content) will be detected how about decomposing them to "en" and "US on the fly to provide more useful data for APM scripting?
| @@ -35,20 +35,23 @@ import com.cognifide.apm.core.grammar.utils.ImportScript | |||
| import com.cognifide.apm.core.grammar.utils.RequiredVariablesChecker | |||
| import com.cognifide.apm.core.logger.Position | |||
| import com.cognifide.apm.core.logger.Progress | |||
| import com.cognifide.apm.core.method.MethodInvoker | |||
There was a problem hiding this comment.
mixing kt with java is a mess, are you planning to remove kt ?
There was a problem hiding this comment.
yes, I'm planning that
No description provided.