Feature/add jcr resource reader #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 23, 2020 09:34
royteeuwen
force-pushed
the
feature/add-jcr-resource-reader
branch
from
13b2450 to
fbfde0d
Compare
pun-ky
reviewed
Aug 1, 2020
| @@ -102,7 +108,9 @@ private void stop() { | |||
| @Override | |||
| public void runScript(Resource resource) { | |||
| final StubScript script = new StubScript(resource, manager, this); | |||
|
|
|||
| final JcrResourceReaderFactory jcrResourceReaderFactory = new JcrResourceReaderFactory(resolverAccessor); | |||
There was a problem hiding this comment.
What is a purpose of MethodClosure here?
There was a problem hiding this comment.
The reason is so that you can use the same syntax as Moco, just method names instead of object.methodName. The methodclosure exposes the object’s method as global function in the groovyscripts instead of resourceFactory.jcr
| try { | ||
| result.set(IOUtils.toString(inputStream, StandardCharsets.UTF_8)); | ||
| } catch (IOException e) { | ||
| LOG.warn("Could not read input stream", e); |
There was a problem hiding this comment.
Maybe put path in message to make it contextual.
How about throwing exception here to make it more strict?
|
any update on this @pun-ky |
|
thanks for reminder ;) today I will check it. hopefully in the evening. |
marcinkp
requested changes
Nov 2, 2020
|
|
||
| @Override | ||
| public MediaType getContentType(HttpRequest request) { | ||
| return MediaType.HTML_UTF_8; |
There was a problem hiding this comment.
What if one would like to control returned mediatype?
I believe text/plain as default would be better
marcinkp
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of a jcr resource reader in moco