Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment hosts conventions #444

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Conversation

pun-ky
Copy link
Contributor

@pun-ky pun-ky commented Aug 29, 2019

Motivation of this to be able to easy reuse host names defined in one place
also in custom tasks scripting:

wttech/gradle-aem-multi#67
wttech/gradle-aem-multi#68

to be able to write: aem.environment.hosts.live.httpUrl instead of hardcoding same domain in multiple places

or aem.environment.hosts.author.httpUrl etc

@pun-ky pun-ky added this to the 7.1.0 milestone Aug 29, 2019
@pun-ky pun-ky changed the base branch from master to develop August 29, 2019 13:24
@pun-ky
Copy link
Contributor Author

pun-ky commented Aug 31, 2019

Demo, live too detailed. Maybe better just 'publish' and treat first publish host as for tests

@pun-ky
Copy link
Contributor Author

pun-ky commented Sep 2, 2019

final DSL

aem {
        hosts {
            author("http://author.example.com")
            publish("http://demo.example.com") { tag("test") }
            publish("http://example.com") { tag("live") }
            other("http://dispatcher.example.com")
        }
}

then

aem.environment.hosts.publish.url (return first tagged "publish")
or
aem.environment.hosts.find("publish, "live").url

@pun-ky pun-ky merged commit 84ead38 into develop Sep 2, 2019
@dprzybyl dprzybyl deleted the environment-hosts-conventions branch November 13, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant