Merge pull request #352 from colorfulldays/bugfix_js_notempty_gqs

fix: js string notempty
wuba · Sep 25, 2023 · 34a4c09 · 34a4c09
2 parents c853f88 + cb7cb91
commit 34a4c09
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/dart2js/core-types/string.js b/dart2js/core-types/string.js
@@ -27,7 +27,7 @@ Object.defineProperties(String.prototype, {
   },
   isNotEmpty: {
     get: function () {
-      return this.length;
+      return !this.isEmpty;
     },
   },
   // runes: {

diff --git a/fair/assets/fair_core/fair_jsbase.js b/fair/assets/fair_core/fair_jsbase.js
@@ -1772,7 +1772,7 @@ Object.prototype.__op_idx__ = function (key) {
     },
     isNotEmpty: {
       get: function () {
-        return this.length;
+        return !this.isEmpty;
       },
     },
     // runes: {