Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix envar writer output type #21

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Fix envar writer output type #21

merged 1 commit into from
Dec 8, 2024

Conversation

pklaschka
Copy link
Member

@pklaschka pklaschka commented Dec 8, 2024

Summary

n/a

Details

n/a

Additional information

n/a

Related links

  • Fixes # .

CLA

  • I have signed the individual contributor's license agreement and sent it to the board of the WüSpace e. V. organization.

@Copilot Copilot bot review requested due to automatic review settings December 8, 2024 22:16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

lib/writers/envar.ts:54

  • [nitpick] The comment '/* convert to Promise */' is unclear. It should provide more detail on how to achieve the conversion.
return prev.trimEnd() + `\n  ]).then(/* convert to Promise<void> */);
@pklaschka pklaschka merged commit 1166852 into main Dec 8, 2024
3 checks passed
@pklaschka pklaschka deleted the fix-envar-types branch December 8, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant