Use submodules instead of exported namespaces in @wuespace/telestion
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
pklaschka
force-pushed
the
01-12-Use_submodules_instead_of_exported_namespaces_in_wuespace/telestion_
branch
from
6e8f9ce to
229af07
Compare
pklaschka
force-pushed
the
01-12-Use_submodules_instead_of_exported_namespaces_in_wuespace/telestion_
branch
from
229af07 to
18d4d9d
Compare
pklaschka
added
📕 documentation
Graphite App
pklaschka
force-pushed
the
01-12-Use_submodules_instead_of_exported_namespaces_in_wuespace/telestion_
branch
from
18d4d9d to
f4dbb50
Compare
Base automatically changed from
01-12-TELESTION-450_Re-export_NATS_for_convenience
to
main
January 17, 2024 15:51
Previously, anything that wasn't exported on the root level of the `@wuespace/telestion` library had to be imported indirectly through namespaces: ```ts import { utils } from '@wuespace/telestion'; const { wait } = utils; ``` This didn't provide a great developer experience, as imports couldn't be reoslved automatically. Instead, these features now must be imported using submodules / path imports: ```ts import { wait } from '@wuespace/telestion/utils'; ``` As of the time of this change, a total of six of these modules exist: - `@wuespace/telestion/application`, corresponding to `import { application } from '@wuespace/telestion'` - `@wuespace/telestion/auth`, corresponding to `import { auth } from '@wuespace/telestion'` - `@wuespace/telestion/nats`, corresponding to `import { nats } from '@wuespace/telestion'` - `@wuespace/telestion/user-data`, corresponding to `import { userData } from '@wuespace/telestion'` - `@wuespace/telestion/utils`, corresponding to `import { utils } from '@wuespace/telestion'` - `@wuespace/telestion/widget`, corresponding to `import { widget } from '@wuespace/telestion'` The previous namespaces were removed.
pklaschka
force-pushed
the
01-12-Use_submodules_instead_of_exported_namespaces_in_wuespace/telestion_
branch
from
f4dbb50 to
7827a43
Compare
pklaschka
deleted the
01-12-Use_submodules_instead_of_exported_namespaces_in_wuespace/telestion_
branch
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, anything that wasn't exported on the root level of the
@wuespace/telestionlibrary had to be imported indirectly through namespaces:This didn't provide a great developer experience, as imports couldn't be reoslved automatically.
Instead, these features now must be imported using submodules / path imports:
As of the time of this change, a total of six of these modules exist:
@wuespace/telestion/application, corresponding toimport { application } from '@wuespace/telestion'@wuespace/telestion/auth, corresponding toimport { auth } from '@wuespace/telestion'@wuespace/telestion/nats, corresponding toimport { nats } from '@wuespace/telestion'@wuespace/telestion/user-data, corresponding toimport { userData } from '@wuespace/telestion'@wuespace/telestion/utils, corresponding toimport { utils } from '@wuespace/telestion'@wuespace/telestion/widget, corresponding toimport { widget } from '@wuespace/telestion'The previous namespaces were removed.