【完善】ECharts-JSX 重写地图图表 #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
【完善】ECharts-JSX重写地图图表
TechQuery
requested changes
Dec 17, 2024
| chart.setOption(chartOptions); | ||
|
|
||
|
|
||
| this.renderChart(chartOptions); |
There was a problem hiding this comment.
JSX 渲染方法应由组件引擎调用，而不是组件作者直接调用。
Comment on lines
128
to
137
| renderChart(chartOptions: EChartsOption) { | ||
| return ( | ||
| <ec-svg-renderer > | ||
| <ec-geo | ||
| map={this.mapName} | ||
| data={chartOptions.options[0].series[0]?.data} | ||
| /> | ||
| </ec-svg-renderer> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| renderChart(chartOptions: EChartsOption) { | |
| return ( | |
| <ec-svg-renderer > | |
| <ec-geo | |
| map={this.mapName} | |
| data={chartOptions.options[0].series[0]?.data} | |
| /> | |
| </ec-svg-renderer> | |
| ); | |
| } | |
| render() { | |
| const { options } = this.chartOptions; | |
| return ( | |
| <ec-svg-renderer> | |
| <ec-geo | |
| map={this.mapName} | |
| data={options[0].series[0]?.data} | |
| /> | |
| </ec-svg-renderer> | |
| ); | |
| } |
【完善】ECharts-JSX 重写地图图表,已修正代码
|
什么叫重写、重构？就是实现同样的效果，但完全抛弃旧代码，用新库的写法来写。 也就是说，原先所有基于 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
已完成ECharts地图组件替换为ECharts-JSX 地图组件
Close #100