Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[文档][端口] 使用文档中所写的9000端口 #26

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

kewu21
Copy link
Contributor

@kewu21 kewu21 commented Jan 27, 2020

更正了文档的开发指南写的是9000端口可以调试,实际调试中发现index.py因为没有配置端口而使用的是5000.
次pr修复了这个错误,加入9000作为默认启动端口,否则从FC_SERVER_PORT环境变量中读取。

@@ -46,8 +47,8 @@ app.register_blueprint(data, url_prefix=path_prefix)
#使用flask蓝图功能来注册http-router

if __name__ == '__main__':
port = os.environ.get("FC_SERVER_PORT", "9000")
Copy link
Contributor

@rexwangcc rexwangcc Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太了解阿里云,不过 FC_SERVER_PORT 似乎是阿里云Deployment中注册的环境变量,类似GCP或AWS中的env_variables ,保险起见建议改为
port = os.environ.get("FC_SERVER_PORT", "5000")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rexwangcc 谢谢comment,已恢复为9000端口

@kewu21 kewu21 changed the title [文档][端口] 更正文档说明使用5000端口 [文档][端口] 使用文档中所写的9000端口 Jan 27, 2020
Copy link
Contributor

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (然而我并没有权限)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants