Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo to use python 3.6.10 #56

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Update repo to use python 3.6.10 #56

merged 4 commits into from
Jan 30, 2020

Conversation

chenrui333
Copy link
Contributor

Purpose | 本PR解决的问题

Kind of related to #28

  • Closes #

Changes | 本PR的更改

Update repo python version to 3.8

Copy link
Contributor

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, while I agree with using Py3.x everywhere, I'm not sure if Py3.8 is supported by the current deployment to aliyun. @LiuChangFreeman Could you answer this? If it's not supported, we could keep Py3.7, since there are only a few new changes in 3.8 from 3.7 (e.g. the walrus operator, etc.)

@chenrui333
Copy link
Contributor Author

yeah, agree. How does the deployment model look like?

@rexwangcc
Copy link
Contributor

As far as I can tell, it's deployed as a serverless app on Function Compute (which looks similar to Cloud Functions or Lambda Functions), but I could be wrong.

@chenrui333
Copy link
Contributor Author

阿里云好像只用3.6, :sad:

Last Updated: Aug 21, 2019
Function Compute currently supports the following Python runtime environments:

  • Python 2.7 with runtime version 2.7
  • Python 3.6 with runtime version 3

Pretty far behind AWS.

@chenrui333
Copy link
Contributor Author

如果要deploy 到 阿里云上面 我可以帮忙做 infra as code.

@rexwangcc
Copy link
Contributor

rexwangcc commented Jan 30, 2020

如果您是指类似Terraform 之类的,我觉得目前的codebase还没有这个需求,并且代码也没有稳定到需要很成熟的DevOps。不介意的话您可以提交一个issue来记录这个想法。

此外,不介意的话,请您将PR中的版本改为Py3.6 :octocat:

@LiuChangFreeman
Copy link
Contributor

仅限于python3.6的特性

@chenrui333
Copy link
Contributor Author

没问题 我马上改成 python 3.6

@chenrui333
Copy link
Contributor Author

application 端 不一定要用 terraform, 可以用 serverless

@chenrui333 chenrui333 changed the title Update repo to use python 3.8 Update repo to use python 3.6.10 Jan 30, 2020
Copy link
Contributor

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM, docker run -it aliyunfc/runtime-python3.6:build python tells 3.6.3, so there might be some minor tweaks with the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants