Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Ability to pass DOM ID and class to the canvas element #85

Closed
wants to merge 2 commits into from
Closed

Ability to pass DOM ID and class to the canvas element #85

wants to merge 2 commits into from

Conversation

noamyg
Copy link

@noamyg noamyg commented Oct 10, 2019

No description provided.

@noamyg
Copy link
Author

noamyg commented Oct 10, 2019

#84

@noamyg
Copy link
Author

noamyg commented Oct 16, 2019

@wulfsolter please review

@wulfsolter
Copy link
Owner

Please remove changes to package.json and package-lock.json from the PR.

When you are ready for some to review a PR, please tag them in the top right corner where it says "Reviewers"

@wulfsolter wulfsolter changed the title Ability to pass id and class to the canvas Ability to pass DOM ID and class to the canvas element Oct 16, 2019
@noamyg
Copy link
Author

noamyg commented Oct 17, 2019

I've updated them - please consider keeping the dependency changes:

"rxjs": "5.4.2",
"rxjs-compat": "^6.5.3",
"tslib": "^1.10.0",
"typescript": "2.4.1",

This should allow future development in the current versions of typescript and have no drawbacks

@wulfsolter
Copy link
Owner

If you would like to update dependency changes please make that a separate PR on a separate branch. This PR is "Ability to pass DOM ID and class to the canvas element" which has nothing to do with dependencies.

@wulfsolter wulfsolter closed this Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamyg @wulfsolter